I sent you a PM.
I sent you a PM.
You are right, I had one of the Boolean reversed. should be alright now.
Thanks @R.Omer. It works well now.
Using BSS’s Agency theme, I did a quick diff (using winmerge) between the original html and the converted html, and it looks very good. However there are a couple of things which are not right.
- the converter tends to double up the class names on div through out the html file.
shows up as:
<div class="container container">
- It misses out the class names on the body element.
<body id="page-top" data-bs-spy="scroll" data-bs-target="#mainNav" data-bs-offset="54">
shows up as:
Besides that, it was perfect.
In trying to understand the redundant class names, I diffed the json files and there were some differences (Ignoring the missing images etc.) that might give a clue to this, but you’ll be able to assert that.
I noticed the doubling of classes, that’s on my to do list, however, it’s wasn’t a big issue so I pushed it to the back, as for the body class names, I am not converting body at-all, I’m simply working with what’s inside the body, so maybe in future releases I will look into adjusting body tag.
The missing images are an issue of BSS. Just throwing that in here in case you weren’t aware of that. I’m hoping that they remedy that soon.
I know of this, thinking to replace the images with a placeholder image before process begins, what do you think?
I’m not sure how that all works. Just wanted to be sure you guys didn’t put hours of time in trying to fix something with the converter that wasn’t broken in it.
I don’t think it’s a good idea, or maybe as an option for the conversion.
If the export is made without hard coded paths (the default option in export) and the converter does not prepend paths to css, js & images then importing back will be perfect - as long as one sticks to BSS’ standards: assets/css assets/img etc.
Therefore, I believe the fix is to make sure that the converter removes the paths in front of those files.
EDIT: I forgot to mention that the converter does not play nice with navbars, i.e. the navbar object doesn’t appear in the imported project. The functionality is still there when running the page, but it’s not possible to manipulate the navbar within BSS. Instead you get a nav, a UL and LI items.
sorry, but wouldn’t it be convert (Missed the N)?
lol @carliedu , you’re right, typo, I fixed it. thanks
Wow! Worked perfectly.
Very nice, it would be great if you could add more pages to export all together for the project.
I started to see now, if you already have this functionality could you show me?
yes absolutely, in the near future inshaAllah
Impressive work. There’s a bug with Table Headers. They are imported as tr instead of th. Also the content of each cell is repeated.
... <div class="table-responsive"> <table class="table table-striped table-sm"> <thead> <tr> <th scope="col">#</th> <th scope="col">Header</th> <th scope="col">Header</th> <th scope="col">Header</th> <th scope="col">Header</th> </tr> </thead> <tbody> <tr> ...
Please send me your file in my private message, I will look into it. and thanks for the compliment.
Great Tool! Is there gonna be a way to convert a whole project of Html files in the future?
Yes that is the objective.
Very interesting project. I tried it out, and it basically did what it was supposed to do. I don’t know if I would have any use for this in my particular workflow, but it might be useful for very simple sites, or people who have not learned their way around BSS. It is an impressive effort. I will be following your progress closely.
hello @gilmar, this feature (multiple pages in single bsdesign project) is now added to the project. please feel free to test it.
really great work, thank you